Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add riscv64 binaries #1150

Merged
merged 7 commits into from
Jul 30, 2024
Merged

feat: add riscv64 binaries #1150

merged 7 commits into from
Jul 30, 2024

Conversation

qyl27
Copy link
Contributor

@qyl27 qyl27 commented Jul 29, 2024

No description provided.

qyl27 and others added 5 commits July 29, 2024 10:40
github actions, お願い

Signed-off-by: 秋雨落 <i@rain.cx>
Signed-off-by: 秋雨落 <i@rain.cx>
Signed-off-by: 秋雨落 <i@rain.cx>
Signed-off-by: 秋雨落 <i@rain.cx>
@gotson
Copy link
Collaborator

gotson commented Jul 29, 2024

some context would help. I see it's using Dockcross, so that seems alright, but why did the windows dll changed?

i don't know risc-v, what would be the value of os.arch in that case, and do we need to add a mapping in OSInfo ?

@qyl27
Copy link
Contributor Author

qyl27 commented Jul 29, 2024

some context would help. I see it's using Dockcross, so that seems alright, but why did the windows dll changed?

i don't know risc-v, what would be the value of os.arch in that case, and do we need to add a mapping in OSInfo ?

Oh, the changes to windows dll seem like by the bot, should I revert it?
The os info of RISC-V did is riscv64, I had a misunderstanding with the OSInfo class.

Signed-off-by: 秋雨落 <i@rain.cx>
@gotson
Copy link
Collaborator

gotson commented Jul 30, 2024

Oh, the changes to windows dll seem like by the bot, should I revert it?

yes please

The os info of RISC-V did is riscv64, I had a misunderstanding with the OSInfo class.

no that's fine, i checked the code and if the os.info value is the same as the folder name then the loading should be good.

Signed-off-by: 秋雨落 <i@rain.cx>
@qyl27
Copy link
Contributor Author

qyl27 commented Jul 30, 2024

All done.

@gotson
Copy link
Collaborator

gotson commented Jul 30, 2024

Thanks for the PR, a good addition to the project!

@gotson gotson changed the title add: support for riscv64. feat: add riscv64 binaries Jul 30, 2024
@gotson gotson merged commit a4a5d48 into xerial:master Jul 30, 2024
25 checks passed
@sualeh

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants